Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.2 Support #129

Closed
masojus opened this issue May 18, 2017 · 10 comments
Closed

Deprecate Python 3.2 Support #129

masojus opened this issue May 18, 2017 · 10 comments
Assignees

Comments

@masojus
Copy link
Contributor

masojus commented May 18, 2017

Problems described in Issue #126 are a result of a larger issue, as demonstrated in the links mentioned by @baumatron in that bug. Namely, that pip and setuptools dropped support for Python 3.2. Should we follow suit?

We could just drop 3.2 from the Travis config and remove mentions of it in the README and setup.py classifiers, if that's the case.

@craigds
Copy link

craigds commented Aug 2, 2017

Not sure about progress on this, but IME it's very rare for libraries to support python 3.2, and I doubt you've got [m]any users still using it. Most apps switching to python 3.x went directly to 3.3+ because of the reintroduction of u'' literals.

Looks like python 3.2 support is the reason this library is pinning our requests version to <2.11 so we'd appreciate that being dropped so we can upgrade it.

@dkador
Copy link
Contributor

dkador commented Aug 2, 2017

@masojus - I'd be fine with dropping support for 3.2 going forward.

@masojus
Copy link
Contributor Author

masojus commented Aug 3, 2017

We can shuffle this up a bit in priority to hopefully ameliorate the dependency issues @craigds is seeing.

@masojus
Copy link
Contributor Author

masojus commented Aug 5, 2017

@craigds is the issue that the requirements.txt demands requests>=2.5,<2.11.0? To rectify that will require more testing.

@masojus
Copy link
Contributor Author

masojus commented Aug 5, 2017

We could look at what it means to depend upon 2.18.x or something instead, but either way Python 3.2 testing can go away.

@craigds
Copy link

craigds commented Aug 6, 2017

yep that's the issue. I came across this through the git blame, in which that line was added specifically to keep Python 3.2 compatibility: 5706ab3

@BlackVegetable
Copy link
Contributor

This is being addressed in version 0.5.0 #132

@hugovk
Copy link

hugovk commented Oct 20, 2017

Here's the pip installs for keen from PyPI for the last month:

$ pypinfo --percent --pip keen pyversion
python_version percent download_count
-------------- ------- --------------
2.7              63.0%          4,135
3.4              18.5%          1,213
3.6              15.8%          1,039
3.5               2.7%            178
3.7               0.0%              2

How about dropping Python 2.6 as well? It's been EOL since 2013 and pip has already deprecated support for it and will drop it in the next release.

And 3.3 also went EOL last month, perhaps dropping that too?

@tbarn
Copy link
Contributor

tbarn commented Oct 20, 2017

Also based on pip data itself here for 2.6 and here for 3.3, I'm +1 on dropping support of both.

From the pip data, 3.3 is used even less than 2.6.

@BlackVegetable
Copy link
Contributor

Ok. I'm also deprecating 2.6 and 3.3 with the same PR. This thing is getting pretty unwieldy. I'm glad it is being merged today at last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants