Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chase.com login fields fail to detect as of version 1.3.2 #386

Closed
tfvlrue opened this issue Jan 18, 2019 · 2 comments · Fixed by #387
Closed

Chase.com login fields fail to detect as of version 1.3.2 #386

tfvlrue opened this issue Jan 18, 2019 · 2 comments · Fixed by #387
Labels

Comments

@tfvlrue
Copy link

tfvlrue commented Jan 18, 2019

Expected Behavior

Login fields should be detected on all websites.

Current Behavior

The login fields on https://www.chase.com/ are no longer detected as of version 1.3.2

Possible Solution

Tested in Firefox 64.0.2 and Chrome 71. This looks like a regression in version 1.3.2. I reverted back to 1.3.1 in Firefox and the login fields were detected once I clicked the "Redetect login fields" button.

Steps to Reproduce (for bugs)

  1. Navigate to https://www.chase.com, making sure the browser is full screen
  2. The login box will appear in the upper right after a second.
  3. Notice the fields are not auto-detected.
  4. Click the "Redetect login fields" button. Notice they are still not detected (password generation icon does not appear, and credentials do not auto-fill). In version 1.3.1, it worked.

Debug info

KeePassXC - 2.41
KeePassXC-Browser - 1.3.2
Operating system: Windows 7
Browser: Chrome/Firefox

Thanks for looking into it. Let me know if there's any other info I can provide.

@droidmonkey
Copy link
Member

I can confirm this as well

@varjolintu varjolintu added the bug label Jan 18, 2019
@varjolintu
Copy link
Member

It's broken by #371. I made a fix where I moved some of the behaviour to be executed in each frame. Some sites need this.

I also noticed that the site URL varies a lot. Even when you go to the frontpage, the actual URL for the login is always secure05b.chase.com or similar. This is why the entry URL should be https://chase.com so it will be handled as https://*.chase.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants