Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root folder for Temporal stuff #16

Closed
michael-rubel opened this issue Sep 22, 2023 · 3 comments · Fixed by #18
Closed

Root folder for Temporal stuff #16

michael-rubel opened this issue Sep 22, 2023 · 3 comments · Fixed by #18

Comments

@michael-rubel
Copy link
Contributor

Hi @cappuc

Wouldn't it be better to have Workflows and Activities registered automatically/placed by artisan commands in the app/Temporal folder instead of the root? In bigger projects that's a good separation because you can instantly see it's Temporal-related, especially if you have Actions and other Laravel layers in the root.

Currently:

Screenshot_1

It could have been:

Screenshot_2

@cappuc
Copy link
Contributor

cappuc commented Sep 22, 2023

Yes it makes sense to group Workflows and Activities under a Temporal namespace.

For autodiscovery we can simply add the new namespace but for the make commands we should check if the project is using the new or the old structure and generate the class in the right namespace

@cappuc
Copy link
Contributor

cappuc commented Sep 25, 2023

Hi @michael-rubel
I've added support for the Temporal root namespace in 0.6.9.
If you want to use it, you just need to move existing workflows and activities to App\Temporal\Workflows and App\Temporal\Activities namespaces

@michael-rubel
Copy link
Contributor Author

@cappuc Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants