Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorect installation instructions or bug during installation. #14

Closed
andreibaca opened this issue Jan 28, 2024 · 1 comment
Closed

Comments

@andreibaca
Copy link
Contributor

The readme file suggests to publish the migration before running artisan migrate.

php artisan vendor:publish --tag="campaigns-migrations"
php artisan migrate

but in the service provider class CampaignsServiceProvider the configurePackage method already instructs the application to run the migration from the vendor folder.

    {
        $package
            ->name('campaigns')
            ->hasConfigFile()
            ->hasMigrations([
                'create_zoho_campaigns_tokens_table',
            ])
            ->runsMigrations()
            ->hasCommands([
                SetupCommand::class,
            ]);
    }

which results in double migration attempt and failing the second migration.

@cappuc
Copy link
Contributor

cappuc commented Feb 1, 2024

Fixed in v0.2

@cappuc cappuc closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants