Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort connection in numerical comparison for Download, DL Speed, etc #367

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Jeremy-Hibiki
Copy link
Contributor

Use valueFormatter to only change the way data is displayed, without altering the data itself, so that columns can be sorted by numerical comparison.

For example, 200 and 1000 would be displayed as the strings 200 B and 1 KB, but still compared numerically as 200 < 1000, rather than by the dictionary order of the strings.

close #336

Copy link
Collaborator

@greenhat616 greenhat616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greenhat616 greenhat616 merged commit 11195fc into libnyanpasu:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“连接”选项卡中升降序按字典序
2 participants