Implement UperReader for ScopedBitReader over Bits #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementations of UperReader required that a user have an implementation of `Bits` or a handful of other types (some primitives) in order to get a `UperReader` instance. However, the underlying implementation was designed to be generic over anything implementing `ScopedBitReader`. This commit removes the hard reliance on `Bits` in favor of being generic over `ScopedBitReader`. Users can now provide their own type implementing `ScopedBitReader` so and get their own implementation of `UperReader`. This is useful for streams of data which may not be easily represented as a `Bits`.
kellerkindt
approved these changes
Aug 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementations of
UperReaderrequired that a user have an implementation ofBitsor a handful of other types (some primitives) in order to get aUperReaderinstance. However, the underlying implementation was designed to be generic over anything implementingScopedBitReader. This commit removes the hard reliance onBitsin favor of being generic overScopedBitReader. Users can now provide their own type implementingScopedBitReaderso and get their own implementation ofUperReader. This is useful for streams of data which may not be easily represented as aBits.