This repository has been archived by the owner on Oct 2, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Why does everything in the API return a game? #37
Labels
Comments
I don't understand what POST, GET nor PUT means. |
I guess "we" will need to change frontend acording to those REST calls. |
i'd like to have a try with this one |
done! |
@pernilsalat how's this going on? |
I'll release v0.1.1 without this if it's not done today, we need to focus on v0.2.0 |
kenan-rhoton
added
Needs Investigation
2 - Minor
Simple
Easy and quick to fix
and removed
enhancement
labels
Aug 30, 2018
Maybe this has sense to be worked together with #78 (which is supposed to also be done by @pernilsalat, so everything's good) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we have 4 API calls:
game-as-player
object, when only thegame-id
andplayer-id
are needed.game-as-player
object when onlyplayer-id
orerror
are needed.game-as-player
object when onlyok
orerror
are needed. Also, this should be a PUT call (my bad).game-as-player
which is exactly what we want.So 3 of the 4 calls return unnecessary stuff and on top of that actually require specific logic to implement returning this unnecessary stuff (
save-game
has an extra line *just to return the saved-game object`)We should limit the calls to only return what they need. This will possibly require some frontend adaptation.
The text was updated successfully, but these errors were encountered: