You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like your plugin a lot!
To simplify highlighting even more I would like to highlight a complete row by simply clicking once.
Current Behaviour
If we have the following line with | indicating the cursor position: Test of a |sentence
clicking the highlight button results in: Test of a ====|sentence
Expected Behaviour
If we have the following line with | indicating the cursor position: - Test of a |bullet point
clicking the highlight button should result in: ==Test of a |sentence==
How to
In order to implement this we would probably do sth along the following lines:
Adding highlight:
check for an empty selection
if empty:
(save the cursor position)
select the complete line
do highlight as implemented
(unselect and position cursor at original cursor position +2)
Removing highlight:
In order to remove the highlight correctly, the equal signs must can be part of the selection, so it's nearly the same as adding highlight:
check for an empty selection
if empty:
(save the cursor position)
select the complete line
do removal of highlight as implemented
(unselect and position cursor at original cursor position -2)
To prevent the breaking of markdown syntax highlight == must be positioned behind the #, - etc. of headings, bullet points etc.
To do so it should be enough to start the selection at the first letter of the line for adding of highlight or at the first equal sign for removal of highlight: - Test of a |bullet point
clicking the highlight button should result in: - ==Test of a |bullet point==
clicking the highlight button again results in: - Test of a |bullet point
The text was updated successfully, but these errors were encountered:
I like your plugin a lot!
To simplify highlighting even more I would like to highlight a complete row by simply clicking once.
Current Behaviour
If we have the following line with
|
indicating the cursor position:Test of a |sentence
clicking the highlight button results in:
Test of a ====|sentence
Expected Behaviour
If we have the following line with
|
indicating the cursor position:- Test of a |bullet point
clicking the highlight button should result in:
==Test of a |sentence==
How to
In order to implement this we would probably do sth along the following lines:
Adding highlight:
Removing highlight:
In order to remove the highlight correctly, the equal signs must can be part of the selection, so it's nearly the same as adding highlight:
To prevent the breaking of markdown syntax highlight
==
must be positioned behind the#
,-
etc. of headings, bullet points etc.To do so it should be enough to start the selection at the first letter of the line for adding of highlight or at the first equal sign for removal of highlight:
- Test of a |bullet point
clicking the highlight button should result in:
- ==Test of a |bullet point==
clicking the highlight button again results in:
- Test of a |bullet point
The text was updated successfully, but these errors were encountered: