Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MacroError): add MacroError #25

Merged
merged 1 commit into from
Sep 8, 2017
Merged

feat(MacroError): add MacroError #25

merged 1 commit into from
Sep 8, 2017

Conversation

kentcdodds
Copy link
Owner

@kentcdodds kentcdodds commented Sep 8, 2017

What: adds MacroError

Why: to encourage user-friendly error messages (closes #22)

How: Magic. Also updated babel-plugin-tester which kinda messed up snapshots a bit. Sorry.

@@ -35,6 +37,24 @@
"question",
"doc"
]
},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkh44 and @dralletje you all cool with this?

@kentcdodds kentcdodds merged commit e0789a1 into master Sep 8, 2017
@kentcdodds kentcdodds deleted the pr/macro-error branch September 8, 2017 07:01
@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          47     58   +11     
  Branches       10     13    +3     
=====================================
+ Hits           47     58   +11
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386f01b...36bbc50. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default error handling wrapper.
1 participant