Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAMEONLY_ALL_ENEMIES option incorrectly applying to players #744

Open
sk6868 opened this issue Dec 7, 2024 · 0 comments
Open

NAMEONLY_ALL_ENEMIES option incorrectly applying to players #744

sk6868 opened this issue Dec 7, 2024 · 0 comments

Comments

@sk6868
Copy link

sk6868 commented Dec 7, 2024

in create.lua lines 2268-2283:

-- hostile;
if f.state.player then
-- disable on hostile players
if not NAMEONLY_HOSTILE_PLAYERS then
return
end
else
-- disable on hostile NPCS
if not NAMEONLY_HOSTILE_NPCS then
return
end
end
-- disable on attackable units
if not NAMEONLY_ALL_ENEMIES and f.state.attackable then
return
end

should be

-- hostile;
if f.state.player then
-- disable on hostile players
if not NAMEONLY_HOSTILE_PLAYERS then
return
end
else
-- disable on hostile NPCS
if not NAMEONLY_HOSTILE_NPCS then
return
end
-- disable on attackable units
if not NAMEONLY_ALL_ENEMIES and f.state.attackable then
return
end
end

since according to the option description, NAMEONLY_ALL_ENEMIES is under the 'Hostile NPCs' category and should only apply IF the frame does not correspond to that of a player.

Kui Namplates Version 2.29.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant