Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead #374

Closed
anna-geller opened this issue Sep 3, 2024 · 3 comments
Assignees
Labels
area/plugin Plugin-related issue or feature request enhancement New feature or request

Comments

@anna-geller
Copy link
Member

Feature description

Currently, we do our best to use fetchType in all Query and Trigger implementations: https://kestra.io/plugins/plugin-surrealdb/tasks/io.kestra.plugin.surrealdb.query#fetchtype

However, some older plugins like Postgres use the approach with store, fetch, fetchType and fetchOne properties. To keep it maintainable, it seems best to deprecate those and keep the fetchType for consistency.

@anna-geller anna-geller added enhancement New feature or request area/plugin Plugin-related issue or feature request labels Sep 3, 2024
@kestrabot kestrabot bot added this to Issues Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Sep 3, 2024
@mgabelle
Copy link
Contributor

mgabelle commented Sep 9, 2024

After taking a quick look I understand that fetchType can be STORE, FETCH, FETCH_ONE, or NONE so it is useful to deprecate store, fetch, fetchType, and fetchOne.
But why do we want to deprecate fetchSize ?

@Ben8t
Copy link
Member

Ben8t commented Sep 9, 2024

Indeed fetchSize is needed for fetchType: FETCH. We should keep it for now.

@anna-geller anna-geller changed the title Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, ... instead Sep 9, 2024
@Ben8t Ben8t changed the title Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, ... instead Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead Sep 9, 2024
@anna-geller
Copy link
Member Author

thx Ben!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Plugin-related issue or feature request enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants