You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, some older plugins like Postgres use the approach with store, fetch, fetchType and fetchOne properties. To keep it maintainable, it seems best to deprecate those and keep the fetchType for consistency.
The text was updated successfully, but these errors were encountered:
After taking a quick look I understand that fetchType can be STORE, FETCH, FETCH_ONE, or NONE so it is useful to deprecate store, fetch, fetchType, and fetchOne.
But why do we want to deprecate fetchSize ?
Indeed fetchSize is needed for fetchType: FETCH. We should keep it for now.
anna-geller
changed the title
Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead
Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, ... instead
Sep 9, 2024
Ben8t
changed the title
Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, ... instead
Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead
Sep 9, 2024
Feature description
Currently, we do our best to use
fetchType
in allQuery
andTrigger
implementations: https://kestra.io/plugins/plugin-surrealdb/tasks/io.kestra.plugin.surrealdb.query#fetchtypeHowever, some older plugins like Postgres use the approach with
store
,fetch
,fetchType
andfetchOne
properties. To keep it maintainable, it seems best to deprecate those and keep thefetchType
for consistency.The text was updated successfully, but these errors were encountered: