Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS conflicts with _bs.scss #183

Closed
nateplusplus opened this issue Jul 7, 2016 · 4 comments
Closed

CSS conflicts with _bs.scss #183

nateplusplus opened this issue Jul 7, 2016 · 4 comments

Comments

@nateplusplus
Copy link

Hey, really small note, but I just thought I would bring it up in case it presents problems with others: there is a style in _bs.scss that was messing with all our styles site-wide and I thought you might want to limit css styles to elements within the formBuilder plugin in order to avoid these conflicts.

The particular style that we had trouble with was:

* {
 -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}

Usually I prefer this type of box-sizing anyway, but there were a few things that got really screwy when it was suddenly applied to every element everywhere.

Perhapse it's better to change this to:

.form-wrap.form-builder * {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}
@kevinchappell
Copy link
Owner

I tackled this just last week on Formeo and agree it should be changed in formBuilder as well. Will try to push a fix for it today.

@nateplusplus
Copy link
Author

cool beans, thanks Kevin! There's also some issues with labels... there might be others that need to be confined to formBuilder too.

@kevinchappell
Copy link
Owner

I forgot to put it in the pull request but this should be resolved in #187 . Closing for now but if its still an issue feel free to reopen.

@willtcarey
Copy link

@kevinchappell The method of encapsulating the styles in _bs.scss looks like it has changed a couple of times but it appears it was removed in the the patch that landed custom controls, seen here.

If that wasn't intentional I'd be happy to submit a pull request to restore that behavior as I'm on a project not using bootstrap and this is screwing with some of styles outside of the form builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants