Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JVM 11 #54

Closed
sargunv opened this issue Jan 8, 2025 · 5 comments
Closed

Support JVM 11 #54

sargunv opened this issue Jan 8, 2025 · 5 comments
Milestone
0.1.1

Comments

@sargunv
Copy link

sargunv commented Jan 8, 2025

The .meters helpers are inline, but built with Java 19 bytecode and so can't be inlined into Android projects with a Java 11 target. The error:

Cannot inline bytecode built with JVM target 19 into bytecode that is being built with JVM target 11. Please specify proper '-jvm-target' option

As this is a pretty general purpose library, it'd be nice to support any non-EOL java version (so, back to 8 or 11 at least)
@sargunv sargunv mentioned this issue Jan 8, 2025
Draft
@JakeWharton
Copy link
Contributor

#52

@kevincianfarini
Copy link
Owner

Yeah this has been merged and will be released in 0.1.1

@kevincianfarini
Copy link
Owner

I also suppose I could release this as 0.1.1 and then follow up other changes in 0.1.2

@kevincianfarini kevincianfarini added this to the 0.1.1 milestone Jan 8, 2025
@kevincianfarini
Copy link
Owner

Completed and processing release now. https://github.com/kevincianfarini/alchemist/releases/tag/0.1.1

@sargunv
Copy link
Author

sargunv commented Jan 8, 2025

Ah nice, I should've searched PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
3 participants
@JakeWharton @sargunv @kevincianfarini