Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove roles from users when role is deleted #1640

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

kevinpapst
Copy link
Member

Description

Fixes #1588

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Apr 15, 2020
@kevinpapst kevinpapst added this to the 1.9 milestone Apr 15, 2020
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1640 into master will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@            Coverage Diff            @@
##             master    #1640   +/-   ##
=========================================
  Coverage     92.17%   92.17%           
- Complexity     4774     4777    +3     
=========================================
  Files           443      443           
  Lines         14787    14800   +13     
=========================================
+ Hits          13630    13642   +12     
- Misses         1157     1158    +1     
Impacted Files Coverage Δ Complexity Δ
src/Repository/UserRepository.php 83.33% <88.88%> (+0.38%) 39.00 <2.00> (+2.00)
src/Controller/PermissionController.php 93.26% <100.00%> (+0.26%) 24.00 <3.00> (+1.00)

@kevinpapst kevinpapst merged commit 4254c25 into master Apr 15, 2020
@kevinpapst kevinpapst deleted the fix-delete-role branch April 15, 2020 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optical error when deleting roles
1 participant