Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /proc/self/mountinfo instead of mount for checking secure mount point #317

Closed
THS-on opened this issue Jan 28, 2022 · 1 comment
Closed

Use /proc/self/mountinfo instead of mount for checking secure mount point #317

THS-on opened this issue Jan 28, 2022 · 1 comment
Assignees
@ansasaki
Labels
bug Something isn't working critical must fix for rust agent release

Comments

@THS-on
Copy link
Member

THS-on commented Jan 28, 2022

The output of mount does not escape spaces which might lead to unexpected behavior that fools the agent that the mount is actually there: GHSA-wj36-qcfg-5j52

We fixed this in the Python agent by parsing /proc/self/mountinfo instead. I think the rust agent is also affected by this.

Logic from the Python agent can be found here: https://github.com/keylime/keylime/blob/15663f08b5d94ae716cd971b8a1215121cc1acb1/keylime/secure_mount.py#L19-L60
@lkatalin lkatalin added bug Something isn't working critical must fix for rust agent release labels Feb 1, 2022
@ansasaki ansasaki mentioned this issue Apr 25, 2022
Merged
@ansasaki ansasaki self-assigned this Apr 25, 2022
@ansasaki
Copy link
Contributor

Fixed via #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansasaki ansasaki

Labels
bug Something isn't working critical must fix for rust agent release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@THS-on @lkatalin @ansasaki