Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtAuth, OAuth config - allow to set clientId with reference #7061

Closed
mwieczorek opened this issue Aug 31, 2022 · 2 comments
Closed

ExtAuth, OAuth config - allow to set clientId with reference #7061

mwieczorek opened this issue Aug 31, 2022 · 2 comments
Labels
stale Issues that are stale. These will not be prioritized without further engagement on the issue. Type: Enhancement New feature or request

Comments

@mwieczorek
Copy link

Version

1.12.x (latest stable)

Is your feature request related to a problem? Please describe.

ref: https://docs.solo.io/gloo-edge/latest/guides/security/auth/extauth/oauth/

I'd like to automate the deployment of multiple VS protected with ExtAuth/OAuth config (with Azure AD as issuer). All VS will use the same issuer, but different clientId/clientSecret.
I'd like to also automate the creation of the Azure AD Application (and its secret) inside the k8s cluster (an open discussion about supporting Azure AD apps in azure-service-operator: Azure/azure-service-operator#2474).
In case azure-service-operator supports AAD Apps (and f.e. keep clientId and clientSecret in k8s Secret resource) I still cannot pass the clientId of created App to AuthConfig.

Describe the solution you'd like

Extend AuthConfig (oidcAuthorizationCode) with a new field:
clientIdRef - it will behave in a similar way to clientSecretRef: it will accept a reference to a k8s secret and take clientId from a defined field in that secret

Describe alternatives you've considered

the only way to do it today is to create the Azure AD App before deploying AuthConfig

Additional Context

No response

@mwieczorek mwieczorek added the Type: Enhancement New feature or request label Aug 31, 2022
Copy link

github-actions bot commented Jun 5, 2024

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

@github-actions github-actions bot added the stale Issues that are stale. These will not be prioritized without further engagement on the issue. label Jun 5, 2024
Copy link

This issue has been closed due to no activity in the last 12 months.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that are stale. These will not be prioritized without further engagement on the issue. Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant