Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[molecule] get tests to pass again #435

Merged
merged 1 commit into from
Oct 11, 2021
Merged

[molecule] get tests to pass again #435

merged 1 commit into from
Oct 11, 2021

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Oct 8, 2021 •
edited
Loading

Part of the behavior change appears to be due to ansible query/lookup changes which I believe is due to ansible-collections/kubernetes.core#147

Get these tests to work again.

part of: kiali/kiali#4417

@jmazzitelli jmazzitelli added test: molecule Molecule test infrastructure and tests themselves backport/v1.36 labels Oct 8, 2021
@jmazzitelli jmazzitelli self-assigned this Oct 8, 2021
@jmazzitelli jmazzitelli marked this pull request as draft October 8, 2021 20:26
@jmazzitelli jmazzitelli force-pushed the molecule-tests-4417 branch 2 times, most recently from ea3e6e6 to 2889cc2 Compare October 8, 2021 21:27
@jmazzitelli
Copy link
Contributor Author

passes on minikube now:

=====================
=== TEST RESULTS: ===
=====================

              accessible-namespaces-test... success [6m 17s]
     affinity-tolerations-resources-test... success [3m 31s]
                                api-test... success [5m 1s]
                      config-values-test... success [3m 5s]
                  default-namespace-test... success [3m 13s]
                            grafana-test... success [4m 15s]
                        header-auth-test... success [2m 17s]
                      instance-name-test... success [3m 1s]
                             jaeger-test... success [2m 53s]
                            metrics-test... success [4m 9s]
                     null-cr-values-test... success [2m 13s]
                only-view-only-mode-test... success [2m 56s]
                             openid-test... success [2m 16s]
                     openshift-auth-test... skipped
                   os-console-links-test... skipped
                 read-certs-secrets-test... success [2m 14s]
                              roles-test... success [5m 20s]
                    rolling-restart-test... success [2m 33s]
                              token-test... success [2m 37s]

@jmazzitelli jmazzitelli mentioned this pull request Oct 8, 2021
Merged
@jmazzitelli jmazzitelli marked this pull request as ready for review October 8, 2021 23:50
@jmazzitelli
Copy link
Contributor Author

this looks like its working for OpenShift (testing with OLM/OSSM 2.1)... some expected failures because I was not testing in the v1.36 branch so some molecule tests in master branch won't pass when run against a 1.36 server. I'll try again using the backport PR #436 to see how it works with testing in OSSM 2.1. Then I'll test master using a stock OpenShift cluster with upstream Istio.

@jmazzitelli
Copy link
Contributor Author

testing on OpenShift with everything installed via OLM passes.. see: #436 (comment)

jshaughn
jshaughn approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes TODO is important :) Good fix.

@jmazzitelli
Copy link
Contributor Author

OpenShift testing with upstream Istio - all pass. This and its companion PR are ready for merge:

=====================
=== TEST RESULTS: ===
=====================

              accessible-namespaces-test... success [9m 2s]
     affinity-tolerations-resources-test... success [7m 42s]
                                api-test... success [6m 38s]
                      config-values-test... success [6m 12s]
                  default-namespace-test... success [3m 43s]
                            grafana-test... success [8m 1s]
                        header-auth-test... skipped
                      instance-name-test... success [6m 22s]
                             jaeger-test... success [6m 10s]
                            metrics-test... success [7m 12s]
                     null-cr-values-test... success [3m 41s]
                only-view-only-mode-test... success [5m 40s]
                             openid-test... skipped
                     openshift-auth-test... success [4m 3s]
                   os-console-links-test... success [10m 31s]
                 read-certs-secrets-test... success [3m 28s]
                              roles-test... success [12m 4s]
                    rolling-restart-test... success [5m 57s]
                              token-test... success [4m 11s]

@jmazzitelli jmazzitelli merged commit 63b7ea5 into kiali:master Oct 11, 2021
@jmazzitelli jmazzitelli deleted the molecule-tests-4417 branch October 11, 2021 15:33
@jshaughn jshaughn added the backport completed obsolete/historical - label issues, not prs when backporting label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
backport completed obsolete/historical - label issues, not prs when backporting test: molecule Molecule test infrastructure and tests themselves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn