From ffe8248d9e407d6506daaecd5dc71dcec53ac0fe Mon Sep 17 00:00:00 2001 From: Kian Thompson <102998837+kian-thompson@users.noreply.github.com> Date: Thu, 8 Aug 2024 16:30:19 -0700 Subject: [PATCH] Use the correct settings for compression combinations test (#22147) A change in `compatUtils.ts` means that we aren't using the defaults from the ContainerRuntime. Thus, this test isn't actually testing what we want. This wasn't causing any failures or flaky behavior, but it needed to be corrected. --- .../src/test/compression.spec.ts | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/test/test-end-to-end-tests/src/test/compression.spec.ts b/packages/test/test-end-to-end-tests/src/test/compression.spec.ts index aa843cc10252..5e6af04c50e0 100644 --- a/packages/test/test-end-to-end-tests/src/test/compression.spec.ts +++ b/packages/test/test-end-to-end-tests/src/test/compression.spec.ts @@ -135,13 +135,15 @@ const compressionSuite = (getProvider) => { this.skip(); } await setupContainers({ - compressionOptions: option.compressionAndChunking.compression - ? { - minimumBatchSizeInBytes: 10, - compressionAlgorithm: CompressionAlgorithms.lz4, - } - : undefined, - chunkSizeInBytes: option.compressionAndChunking.chunking ? 100 : undefined, + compressionOptions: { + minimumBatchSizeInBytes: option.compressionAndChunking.compression + ? 10 + : Number.POSITIVE_INFINITY, + compressionAlgorithm: CompressionAlgorithms.lz4, + }, + chunkSizeInBytes: option.compressionAndChunking.chunking + ? 100 + : Number.POSITIVE_INFINITY, enableGroupedBatching: option.grouping, }); const values = [