Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build project #100

Closed
AlexReff opened this issue Mar 11, 2020 · 5 comments
Closed

Cannot build project #100

AlexReff opened this issue Mar 11, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@AlexReff
Copy link

AlexReff commented Mar 11, 2020

Desktop (please complete the following information):

  • OS: [Windows 10]
  • Version [Git Master branch]

Describe the bug
I tried pulling the project locally, but I cannot get it to build. I keep getting this error:

Error: C:\Projects\fraidycat\node_modules\app-builder-bin\win\x64\app-builder.exe exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE

I tried googling but didn't find anything useful. Are you able to pull on a blank Windows VM and see if you can get it running?

Steps to Reproduce

  1. Pull Repo
  2. npm install
  3. npm run electron:setup
  4. npm run electron:windows

npm run electron also fails for me on Windows.

@AlexReff AlexReff added the bug Something isn't working label Mar 11, 2020
@kickscondor
Copy link
Owner

I am not going to get to this until next week at least - anyone else able to troubleshoot this?

Thank you for reporting this - it's important to me that everyone can build the software so that they can do what they want with it.

@johnaoss
Copy link

I seem to be unable to build master on macOS 10.15 Catalina too.

Following these steps:

npm install
npm run electron:mac

Provides me with the fatal error

electron-builder -m                                                                                                                                                                                                                              2581ms  Thu 12 Mar 22:40:37 2020
  • electron-builder  version=22.4.1 os=19.3.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • rebuilding native dependencies  [email protected], [email protected] platform=darwin arch=x64
  • packaging       platform=darwin arch=x64 electron=7.1.14 appOutDir=dist/mac
  ⨯ image: unknown format
github.com/develar/go-fs-util.CloseAndCheckError
	/Volumes/data/go/pkg/mod/github.com/develar/[email protected]/fs.go:117
github.com/develar/app-builder/pkg/icons.DecodeImageAndClose
	/Volumes/data/Documents/app-builder/pkg/icons/image-util.go:90
github.com/develar/app-builder/pkg/icons.LoadImage
	/Volumes/data/Documents/app-builder/pkg/icons/image-util.go:61
github.com/develar/app-builder/pkg/icons.loadImage
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:334
github.com/develar/app-builder/pkg/icons.configureInputInfoFromSingleFile
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:316
github.com/develar/app-builder/pkg/icons.doConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:241
github.com/develar/app-builder/pkg/icons.ConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:56
github.com/develar/app-builder/pkg/icons.ConfigureCommand.func1
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:33
github.com/alecthomas/kingpin.(*actionMixin).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/actions.go:28
github.com/alecthomas/kingpin.(*Application).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/app.go:557
github.com/alecthomas/kingpin.(*Application).execute
	/Volumes/data/go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/app.go:390
github.com/alecthomas/kingpin.(*Application).Parse
	/Volumes/data/go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/app.go:222
main.main
	/Volumes/data/Documents/app-builder/main.go:90
runtime.main
	/usr/local/Cellar/go/1.14/libexec/src/runtime/proc.go:203
runtime.goexit
	/usr/local/Cellar/go/1.14/libexec/src/runtime/asm_amd64.s:1373
  ⨯ /usr/local/lib/node_modules/electron-builder/node_modules/app-builder-bin/mac/app-builder exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE

And then the following for a stack trace:

Error: /Users/johnoss/Projects/GitClones/fraidycat/node_modules/app-builder-bin/mac/app-builder exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
at ChildProcess.<anonymous> (/Users/johnoss/Projects/GitClones/fraidycat/node_modules/builder-util/src/util.ts:239:14)
at Object.onceWrapper (events.js:297:20)
at ChildProcess.emit (events.js:209:13)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

Seems like https://github.com/develar/app-builder is being used by electron-builder, and may not recognize the image format for whatever reason. I seem to be able to open the built Electron.app in dist/mac, however a few icons seem to not be missing.

image

Hacker News seems to have a proper icon, however https://dataswamp.org/~solene/'s icon seems to fail to render properly.

Seems like electron-userland/electron-builder#4134 had the same issue.

@kickscondor
Copy link
Owner

Can you both try running npm install -D instead of plain npm install?

@kickscondor
Copy link
Owner

Oh you also both need to install git-lfs before cloning. And I need to add that to the instructions!

@johnaoss
Copy link

Thanks for the info!

Running the following seemed to solve that issue.

git clone https://github.com/kickscondor/fraidycat.git
cd fraidycat
git-lfs checkout
npm install -D
npm run electron:mac

Although now it seems to fail at the code signing step, but I'll have to dig a little deeper into that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants