Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Investigate use of data-element in docs #3772

Open
1 task done
RasmusKjeldgaard opened this issue Jan 28, 2025 · 0 comments
Open
1 task done

[Housekeeping] Investigate use of data-element in docs #3772

RasmusKjeldgaard opened this issue Jan 28, 2025 · 0 comments
Labels
accessibility housekeeping 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the housekeeping request

In the cookbook, mainly on the item showcase, we use <data> liberally. I do think it is wrong use of the element, as it should have a value attribute with a machine-readable version of the content in the element.

In a lot of the examples, the data is already machine-readable, and adds no value.

In addition, the missing value appears in automated tests as a accessibility issue for all consuming teams copying our approach.

Are there any additional context?

MDN Docs for data

@RasmusKjeldgaard RasmusKjeldgaard added accessibility housekeeping NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 👶🏻 New For new issues before prioritisation and refinement labels Jan 28, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Jan 28, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to 📙 Backlog in Kirby Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility housekeeping 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: 📙 Backlog
Development

No branches or pull requests

1 participant