Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with python 3.8 #4

Closed
jeblair opened this issue Oct 21, 2019 · 3 comments
Closed

Incompatible with python 3.8 #4

jeblair opened this issue Oct 21, 2019 · 3 comments

Comments

@jeblair
Copy link

jeblair commented Oct 21, 2019

Something about the internals rehash uses seems to have changed in python 3.8.0. This is using the "python:slim" docker image:

Python 3.8.0 (default, Oct 17 2019, 05:48:34) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import rehash, pickle
>>> hasher = rehash.sha256()
>>> pickle.dumps(hasher)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/rehash/__init__.py", line 52, in __getstate__
    ctx = self._get_evp_md_ctx()
  File "/usr/local/lib/python3.8/site-packages/rehash/__init__.py", line 46, in _get_evp_md_ctx
    if hasattr(c_evp_obj.contents.ctx, "contents"):
ValueError: NULL pointer access
@kislyuk
Copy link
Owner

kislyuk commented Oct 22, 2019

Thank you for the report.

This appears to be the culprit: python/cpython@5a4f82f#diff-80bbc723e944ebedb3f450b876b42056L33 - upstream removed a field from the EVPobject struct.

Before I can fix it, I'll need to migrate CI to GitHub Actions.

@kislyuk
Copy link
Owner

kislyuk commented Oct 22, 2019

I migrated CI to github actions, but they don't support Python 3.8 yet: https://github.com/kislyuk/rehash/runs/269186836 - blocked on actions/setup-python#30 for now.

@kislyuk
Copy link
Owner

kislyuk commented Oct 24, 2019

Fixed in v1.0.0., please test.

@kislyuk kislyuk closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants