diff --git a/build/frontend/action.yaml b/build/frontend/action.yaml index 1f51de8d..9079df87 100644 --- a/build/frontend/action.yaml +++ b/build/frontend/action.yaml @@ -236,5 +236,4 @@ runs: cdn_aws_access_key_id: ${{ inputs.cdn_aws_access_key_id }} cdn_aws_secret_access_key: ${{ inputs.cdn_aws_secret_access_key }} cdn_aws_region: ${{ inputs.cdn_aws_region }} - cdn_source_dir: ${{ inputs.cdn_source_dir }} delete: ${{ steps.build-push.outputs.cdn-delete-path }} diff --git a/destroy/action.yaml b/destroy/action.yaml index 2513cc72..4d42bef7 100644 --- a/destroy/action.yaml +++ b/destroy/action.yaml @@ -51,6 +51,30 @@ inputs: default: true type: boolean + cdn_aws_s3_bucket: + required: false + description: "CDN aws s3 bucket" + default: "" + type: string + + cdn_aws_access_key_id: + required: false + description: "CDN aws access key id" + default: "" + type: string + + cdn_aws_secret_access_key: + required: false + description: "CDN aws secret access key" + default: "" + type: string + + cdn_aws_region: + required: false + description: "CDN aws region" + default: "" + type: string + runs: using: "composite" steps: @@ -90,5 +114,4 @@ runs: cdn_aws_access_key_id: ${{ inputs.cdn_aws_access_key_id }} cdn_aws_secret_access_key: ${{ inputs.cdn_aws_secret_access_key }} cdn_aws_region: ${{ inputs.cdn_aws_region }} - cdn_source_dir: ${{ inputs.cdn_source_dir }} delete: ${{ steps.destroy-release.outputs.cdn-delete-path }} diff --git a/packages/cdn/action.yaml b/packages/cdn/action.yaml index 6a9aa05b..83c70932 100644 --- a/packages/cdn/action.yaml +++ b/packages/cdn/action.yaml @@ -9,27 +9,24 @@ inputs: type: string cdn_aws_s3_bucket: - required: false + required: true description: "CDN aws s3 bucket" - default: "" type: string cdn_aws_access_key_id: - required: false + required: true description: "CDN aws access key id" default: "" type: string cdn_aws_secret_access_key: - required: false + required: true description: "CDN aws secret access key" - default: "" type: string cdn_aws_region: - required: false + required: true description: "CDN aws region" - default: "" type: string cdn_source_dir: diff --git a/tools/frontend/nextjs-bundle-analysis/action.yaml b/tools/frontend/nextjs-bundle-analysis/action.yaml index b29fc9e5..3871d06b 100644 --- a/tools/frontend/nextjs-bundle-analysis/action.yaml +++ b/tools/frontend/nextjs-bundle-analysis/action.yaml @@ -46,14 +46,14 @@ runs: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v2 - if: success() && ${{ inputs.pr_number != '' }} + if: success() && inputs.pr_number != '' with: workflow: ${{ inputs.workflow_name }} branch: ${{ inputs.base_branch }} path: ${{ inputs.working_directory }}/.next/analyze/base - name: Compare with base branch bundle - if: success() && ${{ inputs.pr_number != '' }} + if: success() && inputs.pr_number != '' run: | ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare sed -i 's/Next.js Bundle Analysis/${{ inputs.comment_header }}/g' .next/analyze/__bundle_analysis_comment.txt @@ -62,7 +62,7 @@ runs: - name: Get comment body id: get-comment-body - if: success() && ${{ inputs.pr_number != '' }} + if: success() && inputs.pr_number != '' uses: actions/github-script@v6 with: result-encoding: string @@ -73,7 +73,7 @@ runs: - name: Find Comment uses: peter-evans/find-comment@v2 - if: success() && ${{ inputs.pr_number != '' }} + if: success() && inputs.pr_number != '' id: fc with: issue-number: ${{ inputs.pr_number }} @@ -81,14 +81,14 @@ runs: - name: Create Comment uses: peter-evans/create-or-update-comment@v2 - if: success() && ${{ inputs.pr_number != '' }} && steps.fc.outputs.comment-id == 0 + if: success() && inputs.pr_number != '' && steps.fc.outputs.comment-id == 0 with: issue-number: ${{ inputs.pr_number }} body: ${{ steps.get-comment-body.outputs.body }} - name: Update Comment uses: peter-evans/create-or-update-comment@v2 - if: success() && ${{ inputs.pr_number != '' }} && steps.fc.outputs.comment-id != 0 + if: success() && inputs.pr_number != '' && steps.fc.outputs.comment-id != 0 with: issue-number: ${{ inputs.pr_number }} body: ${{ steps.get-comment-body.outputs.body }}