Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "pil" or "pillow" avaliable for Python 3 #1326

Closed
ghost opened this issue Aug 10, 2018 · 9 comments
Closed

No "pil" or "pillow" avaliable for Python 3 #1326

ghost opened this issue Aug 10, 2018 · 9 comments

Comments

@ghost
Copy link

ghost commented Aug 10, 2018

I renamed this issue and contents a couple of times because I'm silly and confused about PIL & pillow. Anyway, the state is that none of them are available with python3crystax since PIL is hard-wired to python 2 and --requirements=pillow doesn't work, since without a recipe it packages the wrong .so library (incorrect architecture). That means, effectively, no PIL/pillow for any python 3 app which is unfortunate 😢


old issue text:

The "pil" recipe is misguidedly hardwired to python 2:

 depends = ['python2', 'png', 'jpeg']

This breaks the build with Python 3:

# p4a apk --debug --private /my-app/ --orientation user --window --package=org.example.myapp --name "My application" --version 0.1 --bootstrap=sdl2 --requirements=python3crystax,pil,sdl2,pysdl2,pyjnius --arch=armeabi-v7a
[INFO]:    Will compile for the following archs: armeabi-v7a
[INFO]:    Found Android API target in $ANDROIDAPI
[INFO]:    Available Android APIs are (19)
[INFO]:    Requested API target 19 is available, continuing.
[INFO]:    Found NDK dir in $ANDROIDNDK
[INFO]:    Got NDK version from $ANDROIDNDKVER
[INFO]:    Using Crystax NDK 10.3.2
[INFO]:    Found virtualenv at /usr/bin/virtualenv
[INFO]:    ccache is missing, the build will not be optimized in the future.
[INFO]:    Found the following toolchain versions: ['4.9', '5', 'clang3.6', 'clang3.7']
[INFO]:    Picking the latest gcc toolchain, here 5
[INFO]:    No existing dists meet the given requirements!
[INFO]:    No dist exists that meets your requirements, so one will be built.
[ERROR]:   Didn't find any valid dependency graphs.
[ERROR]:   This means that some of your requirements pull in conflicting dependencies.
[ERROR]:   Exiting.

I suggest this should be fixed.

@ghost ghost changed the title "pil" recipe doesn't work combined with python3crystax, "pillow" crashes "pil" recipe doesn't work combined with python3crystax, "pillow" crashes on import Aug 10, 2018
@ghost ghost changed the title "pil" recipe doesn't work combined with python3crystax, "pillow" crashes on import "pil" recipe hardwired to python2, breaks python3 build Aug 12, 2018
@ghost
Copy link
Author

ghost commented Aug 12, 2018

Based on a conversation in IRC chat, it seems like this is actually a fault in the pil recipe being hardcoded for Python 2 instead of working with both. I updated the ticket description accordingly.

@AndreMiras
Copy link
Member

From what I recall PIL is deprecated upstream and not compatible with Python3 (also see c60e02d). Pillow is the one that should be used #786 but it's in work in progress.

@ghost
Copy link
Author

ghost commented Aug 12, 2018

Yeah I use pillow in my desktop build. Without it, there's no way I can ever port this application to Android. 😢

@AndreMiras
Copy link
Member

Yep I also need it for one of my apps, but don't have time recently to help with the pull request. If you feel like it please take a look. In the meantime, do you think we can close this issue since PIL is not Python3 compatible upstream anyway?

@ghost
Copy link
Author

ghost commented Aug 12, 2018

Well the problem really is that with Python 3, you have no (PIL)low of any kind. I don't see how that is resolved. I renamed it confused by the situation about the old PIL and python 3 support, but that's because I'm a silly person, not because it would no longer be an issue

@ghost ghost changed the title "pil" recipe hardwired to python2, breaks python3 build No "pil" or "pillow" avaliable for Python 3 Aug 12, 2018
@ghost
Copy link
Author

ghost commented Aug 12, 2018

I changed it back now, sorry for the confusion 😨 I won't touch the issue description anymore now, I promise

@AndreMiras
Copy link
Member

AndreMiras commented Aug 12, 2018

I understand, it's not resolved, my point it's it's already being addressed in #786 so somehow duplicated even though far from being resolved.
Edit: but I'm fine leaving it open 😄

@ghost
Copy link
Author

ghost commented Aug 12, 2018

Well I suggest it would be a good point to close this once the pull request is actually merged! (I think that's how it is commonly done in other projects: having both a ticket & associated pull request) However, if you think it should be closed now, I can close it if you want. It's not like I wanna manage your project for you or something

@AndreMiras
Copy link
Member

#1339 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant