Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android NDK 18b issues #1525

Closed
tito opened this issue Dec 12, 2018 · 5 comments
Closed

Android NDK 18b issues #1525

tito opened this issue Dec 12, 2018 · 5 comments

Comments

@tito
Copy link
Member

tito commented Dec 12, 2018

Libffi latest stable version is incompatible with Android NDK 18b:

../src/arm/sysv.S:363:2: error: invalid instruction, did you mean: fldmiax?
 fldmiadgt ip, {d0-d7}
 ^
../src/arm/sysv.S:399:2: error: invalid instruction
 stmeqia r2, {r0, r1}
 ^
../src/arm/sysv.S:412:2: error: invalid instruction, did you mean: fstmiax?
 fstmiadeq r2, {d0-d3}
 ^
/tmp/sysv-5d4296.s:263:2: error: invalid instruction
 fstmfdd sp!, {d0-d7}
 ^
/tmp/sysv-5d4296.s:313:2: error: invalid instruction, did you mean: fldmiax?
 fldmiad sp, {d0-d1}
 ^
/tmp/sysv-5d4296.s:316:2: error: invalid instruction, did you mean: fldmiax?
 fldmiad sp, {d0-d3}

It appears to be because of clang 7.0, which doesn't accept deprecated functions.
The Android libffi version have fixes: https://android.googlesource.com/platform/external/libffi/+/ca22c3cb49a8cca299828c5ffad6fcfa76fdfa77

Didn't tested if libffi master have the fixes, but stable don't.

@ghost
Copy link

ghost commented Jan 25, 2019

Has this been resolved with r18c or a newer libffi release? I've never seen these problems even using libffi, so maybe we can just tell people to use r18c and it'll work fine for the future

@inclement
Copy link
Member

I found this still happened with NDK 19 in #1612, so we'll need to deal with this it seems.

@dbrnz
Copy link
Contributor

dbrnz commented Feb 11, 2019

FYI, libffi can be made to compile with NDK 19 by setting version = 3.3-rc0 and patches = [] in the libffi recipe.

@inclement
Copy link
Member

Thanks @dbrnz, that's great to know.

@misl6
Copy link
Member

misl6 commented Jul 10, 2022

Fixed via #1722

@misl6 misl6 closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants