Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env variables for ANDROIDAPI ignored #241

Closed
knappador opened this issue May 20, 2014 · 1 comment
Closed

Env variables for ANDROIDAPI ignored #241

knappador opened this issue May 20, 2014 · 1 comment

Comments

@knappador
Copy link
Contributor

Build.py will just use the default from the argparser instead of overwriting it with the shell variable value or using that value as the default in the argparser.

Quick fixes in either AndroidManifest.xml.tmpl or build.py but I don't want to screw up buildozer's expected behavior or I'd patch it myself.

In AndroidManifest.xml.tmpl:
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" androi...

In build.py:

    # Get target android API
    android_api = int(os.environ.get('ANDROIDAPI', '8'))

args.min_sdk_version isn't being overwritten by the shell variable and the shell variable isn't used as the default value in the arg parser. It would seem that shell variables are less specific than args, but really why isn't the API version hard-coded into each build.py considering that the SDK is set during distribute.sh?

@knappador knappador changed the title Env variables for ANDROIDAPI ignored. Possibly others. Env variables for ANDROIDAPI ignored May 20, 2014
@knappador
Copy link
Contributor Author

I'm guessing the spec for buildozer should override? Does it do this through the command line switch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants