Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Setup (Installer) #146

Closed
xmha97 opened this issue May 12, 2021 · 14 comments
Closed

Make Setup (Installer) #146

xmha97 opened this issue May 12, 2021 · 14 comments
Assignees
Labels
enhancement fixed Fixed, awaiting publication in new apps

Comments

@xmha97
Copy link

xmha97 commented May 12, 2021

Hi, Make setup (installer) for Windows 7.
Installer

@kelson42
Copy link
Contributor

@Jaifroid Do we really need this?

@xmha97
Copy link
Author

xmha97 commented May 12, 2021

@Jaifroid Do we really need this?

Yes, I need installer.

@Jaifroid
Copy link
Member

@xmh97 It is better to use the Electron NSIS installer rather than the Suite Installer, because the former can easily be added to the build script for the Electron version (I use Electron-Builder). But could you explain why you cannot use the Portable version (NWJS) I currently provide for Windows 7? I mean this one: https://kiwix.github.io/kiwix-js-windows/kiwix-js-nwjs.html ? When you unzip that, you can simply launch the app with the provided shortcut(s), without having to install anything. I thought it was more convenient than an .exe installer and uninstaller.

@Jaifroid
Copy link
Member

Jaifroid commented May 12, 2021

@xmha97 Have you also considered the PWA version? It is very lightweight and can be installed if you launch it in Chrome or in Edge Chromium. You will find an Install button under Configuration. Please try it out and see if it meets your needs (it also works offline once you've installed it): https://pwa.kiwix.org/. Unlike the NWJS or Electron versions, the PWA keeps itself up-to-date (when you are online).

@Jaifroid
Copy link
Member

Jaifroid commented May 12, 2021

@xmha97 The new release of the WikiMed Electron version now includes an installable (Setup) build for Windows (properly signed) as well as the portable versions for Windows and Linux. Please try it out. Note that this version includes the full latest WikiMed archive in English. If you don't want that, wait for the release of the non-packaged version.

@xmha97
Copy link
Author

xmha97 commented May 12, 2021

@xmha97 The new release of the WikiMed Electron version now includes an installable (Setup) build for Windows (properly signed) as well as the portable versions for Windows and Linux. Please try it out. Note that this version includes the full latest WikiMed archive in English. If you don't want that, wait for the release of the non-packaged version.

Thank you, but the app installed per user.
image
I want to install the app per machine (for all users)
In other words, I want the app to be installed in the %ProgramFiles%
image

@xmha97
Copy link
Author

xmha97 commented May 12, 2021

Also, if possible, create .deb package for Linux.

@Jaifroid
Copy link
Member

@xmha97 I have now changed the Windows installer options so that it gives you a choice of "per user" or "per machine". It's a new installer on the same release https://kiwix.github.io/kiwix-js-windows/wikimed-electron.html, even though it has the same filename as before. I have also provided two Linux deb installer packages for you to test the appropriate one: amd64 (64bit) and i386 (32bit).

Let me know if this resolves this issue. I will release an Electron package of plain Kiwix JS (without WikiMed) in the next release cycle, and it will include these changes.

image

@Jaifroid Jaifroid added the fixed Fixed, awaiting publication in new apps label May 13, 2021
@xmha97
Copy link
Author

xmha97 commented May 15, 2021

Thank you.
The installer is working properly.
I'm waiting for a light version of Kiwix JS to be released.

@xmha97 xmha97 closed this as completed May 15, 2021
@Jaifroid
Copy link
Member

@xmha97 OK, I'll let you know when it's available.

@xmha97
Copy link
Author

xmha97 commented May 16, 2021

Dear @Jaifroid
I have feedback for the Linux version (deb package)
The application has no icons after installation.
I also think the "Education" category is better than the "Utilities" category.
image

@Jaifroid
Copy link
Member

OK, thanks, I'll look into it. I noticed the lack of an icon myself, though I thought I'd set one. Possibly has to be specific for Linux. I agree about category.

@Jaifroid
Copy link
Member

@xmha97 I now have a somewhat experimental release of the "light" packages:

https://kiwix.github.io/kiwix-js-windows/kiwix-js-electron.html

I managed to get an icon into the .deb packages, though I'm not 100% happy with the colour. Will change to darker colour in future, but I can't re-do everything just for an icon. Note that on Debian, there is an issue with all Electron packages (electron/electron#17972 (comment)), which means they have to be run with the --no-sanbox commandline switch (including the AppImage). On Ubuntu, it runs fine without that. There are instructions given on the release page.

image

@xmha97
Copy link
Author

xmha97 commented May 21, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed Fixed, awaiting publication in new apps
Projects
None yet
Development

No branches or pull requests

3 participants