Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After clicking on configuration or random, occasionally the keyboard becomes unresponsive #157

Closed
Jaifroid opened this issue Jun 7, 2021 · 3 comments
Assignees
Labels
bug/non-critical fixed Fixed, awaiting publication in new apps regression
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jun 7, 2021

As title. It is as if some non-scrollable part of the UI has programmatically received focus, and clicking into the article does not alter that focus. Even clicking through to a link fails to focus key presses appropriately in the iframe.

Workaround is to search for an article and load it. Then focus is returned to the article and keyboard works again. Workaround for scrolling is to use mouse / scrollbars.

This would be highly disconcerting bug for users without a touchscreen. It's not clear to me at what point this regression crept in.

@Jaifroid Jaifroid added this to the High priority milestone Jun 7, 2021
@Jaifroid Jaifroid self-assigned this Jun 7, 2021
@Jaifroid
Copy link
Member Author

Jaifroid commented Jun 7, 2021

After further investigation, this is a non-critical bug in jQuery mode, and more of a critical bug in SW mode. Fortunately SW mode is experimental in the UWP app, and is still very much a minor use case for packaged apps (they are optimized for working fast in jQuery mode).

In jQuery mode, after using the random button or the configuration button, the user must click into the article to use keyboard scrolling, but this consistently works. The user can also select text for copy and paste (a useful function).

In SW mode, however, after using the random button (or config) it is impossible to click into the article to focus it. Therefore the only way of regaining focus on the article is as described in my first post above. It is also impossible to select text with the mouse in SW mode. These things are undoubtedly linked. Mousedown is probably being absorbed by the way clicks are detected in SW mode (for opening new windows) and being swallowed under certain circumstances. It is because of this kind of difficulty that we closed kiwix/kiwix-js#680 in Kiwix JS. 😮

@Jaifroid Jaifroid changed the title After clicking on configuration or random, occaionally the keyboard becomes unresponsive After clicking on configuration or random, occasionally the keyboard becomes unresponsive Jun 7, 2021
@Jaifroid Jaifroid added the fixed Fixed, awaiting publication in new apps label Jun 7, 2021
@Jaifroid
Copy link
Member Author

Jaifroid commented Jun 7, 2021

Now fixed and publsihed for Service Worker mode (the mode most affected). For JQuery, this will need to await the update cycle. Fix includes eradication of the underlying issue with click capture on the document, and addition of a focus on the iframe window when the Home tab is displayed.

@Jaifroid
Copy link
Member Author

Now published in the UWP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/non-critical fixed Fixed, awaiting publication in new apps regression
Projects
None yet
Development

No branches or pull requests

1 participant