-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the service worker (or its scope), so that it catches all the request from the iframe, and not the ones from the UI #138
Comments
@kelson42 tells me that the norm is now to have relative URLs everywhere (since the end of 2014). |
I would not recommend to handle cases which are not respecting the ZIM specification. That only makes the code more complicated.... for no added value. I strongly recommend to close this ticket as wont-fix. |
No. There is a regular expression at the beginning of the ServiceWorker that checks if the URL matches a ZIM URL. It ignores the rest, so that everything works. But it would be much better if we managed to make the ServiceWorker catch only the requests that come from the iframe. A solution might be to change our prefix : instead of having only the ZIM file name, we might use something like |
I close this issue as "won't fix" because #764 needs the ServiceWorker to catch all the requests (including the ones from the UI) |
It's a blocker for some ZIM files (for example wikipedia_fr_all_09_2012.zim), which use absolute URLs like /A/Article.html.
And the service-worker.js file should be placed with the other javascript files (if possible)
The text was updated successfully, but these errors were encountered: