Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handling code cleaner and safer #43

Closed
mossroy opened this issue Aug 2, 2013 · 1 comment
Closed

Make error handling code cleaner and safer #43

mossroy opened this issue Aug 2, 2013 · 1 comment
Milestone

Comments

@mossroy
Copy link
Contributor

mossroy commented Aug 2, 2013

The error handling code is not very clean.
We sometimes test on the error message, which is very bad practice
We sometimes put the error message as the article content
We also call alert() from the algorithm, which should not have a dependency on the GUI.

I'm not proud of all this : it's not clean and not bullet-proof

@mossroy
Copy link
Contributor Author

mossroy commented Feb 2, 2022

Almost all of this is now obsolete.
I've created #813 for what's remaining.

@mossroy mossroy closed this as completed Feb 2, 2022
@Jaifroid Jaifroid modified the milestones: Backlog, v3.8 Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants