Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading an article from wasm version of libzim returns too much data #510

Closed
mossroy opened this issue Jun 1, 2019 · 2 comments · Fixed by openzim/javascript-libzim#4
Closed

Reading an article from wasm version of libzim returns too much data #510

mossroy opened this issue Jun 1, 2019 · 2 comments · Fixed by openzim/javascript-libzim#4
Assignees
@mossroy
Labels
bug
Milestone
v3.3

Comments

@mossroy
Copy link
Contributor

mossroy commented Jun 1, 2019

This is a follow-up of #116.

The String result not only contains the requested HTML content : it also usually contains the beginning of another article.
Like if the reading did not stop at the right offset
@mossroy mossroy added the bug label Jun 1, 2019
@mossroy mossroy added this to the v2.6 milestone Jun 1, 2019
@mossroy mossroy self-assigned this Jun 1, 2019
@mossroy mossroy modified the milestones: v2.6, v2.7 Jul 14, 2019
@mossroy mossroy modified the milestones: v2.7, v2.8 Mar 29, 2020
@mossroy mossroy mentioned this issue May 2, 2020
Closed
@mossroy mossroy modified the milestones: v2.8, v2.9 Jul 11, 2020
@Jaifroid Jaifroid modified the milestones: v3.0, v3.1 Oct 3, 2020
@mossroy mossroy mentioned this issue Oct 16, 2020
Closed
@Jaifroid Jaifroid modified the milestones: v3.1, v3.2 Dec 6, 2020
@mossroy mossroy modified the milestones: v3.2, v3.3 Aug 22, 2021
@mossroy
Copy link
Contributor Author

mossroy commented Oct 25, 2021

Upgrading emscripten to version 2.0.32 does not seem to solve this issue

@mossroy mossroy mentioned this issue Oct 27, 2021
Merged
@mossroy
Copy link
Contributor Author

mossroy commented Oct 27, 2021

This has been fixed with the help of @mgautierfr : the C code in demo_file_api.cpp was using a .data() call that was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossroy mossroy

Labels
bug
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

Upgrade libzim to 7.0.0 openzim/javascript-libzim
2 participants
@mossroy @Jaifroid