Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and UI tests on a recent sample ZIM file #748

Closed
mossroy opened this issue Aug 21, 2021 · 4 comments
Closed

Add unit and UI tests on a recent sample ZIM file #748

mossroy opened this issue Aug 21, 2021 · 4 comments
Milestone

Comments

@mossroy
Copy link
Contributor

mossroy commented Aug 21, 2021

Our current unit and UI tests use an old ZIM file : wikipedia_en_ray_charles_2015-06.zim

Since then, the format and contents have evolved : at least zstd compression format, no-namespace ZIM flavor, and webp. These are implemented in kiwix-js, but not covered by our current automatic tests.

While keeping the current tests on the old ZIM file (for non-regression), we should add some on a more recent ZIM file.
Ideally, it would be on the same "Ray Charles" content, so that we could use the same scenario. I've opened openzim/zim-testing-suite#5 to have a suitable ZIM file.

@mossroy mossroy added this to the v3.2 milestone Aug 21, 2021
@mossroy mossroy mentioned this issue Aug 21, 2021
13 tasks
@Jaifroid
Copy link
Member

We already had #718 for this, but I think this issue is more generic, so I'll close that one.

@Jaifroid
Copy link
Member

I think this issue has superseded #456 because it makes sense to continue testing on the old split ZIM for non-regression (as you say, @mossroy) while adding a modern ZIM for no-namespace, zstandard and webp. This gives better coverage than simply updating Ray Charles,

@mossroy
Copy link
Contributor Author

mossroy commented Aug 22, 2021

It would be important to keep the step that checks some images dimensions in the UI scenario, on this newer ZIM file.
Because, when run on browsers that do not support webp (IE11, Firefox 45), it would check that the webp polyfill works properly (instead of implementing #674)

@Jaifroid Jaifroid modified the milestones: v3.3, v3.4, v3.5 Jan 31, 2022
@Jaifroid Jaifroid modified the milestones: v3.9, v4.0 Apr 22, 2023
@Jaifroid
Copy link
Member

Closed in favour of #1042.

@Jaifroid Jaifroid modified the milestones: v4.1, v3.10 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants