Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important committers are totally forgotten #65

Open
kelson42 opened this issue Oct 18, 2020 · 8 comments
Open

Important committers are totally forgotten #65

kelson42 opened this issue Oct 18, 2020 · 8 comments
Assignees
Labels
bug Something isn't working stale

Comments

@kelson42
Copy link
Collaborator

The top committers for the kiwix-android project are not the correct ones.

@kelson42 kelson42 added the bug Something isn't working label Oct 18, 2020
@kelson42
Copy link
Collaborator Author

kelson42 commented Dec 1, 2020

@florentk
Copy link
Collaborator

florentk commented Dec 1, 2020

@kelson42 On this graph we can't show top 10 commiter dynamiquely. We filter with a short fixed list of 10 authors. We need to update this list by hand. For that, this list can help you.

@kelson42
Copy link
Collaborator Author

kelson42 commented Dec 2, 2020

@florentk Which file should I update in the source code to extend the list of developers?

@florentk
Copy link
Collaborator

florentk commented Dec 2, 2020

@kelson42 this is in a config file :

"searchSourceJSON": "{\"index\":\"26d36150-0f7c-11ea-ae8c-d9e77f11fa16\",\"filter\":[{\"meta\":{\"index\":\"26d36150-0f7c-11ea-ae8c-d9e77f11fa16\",\"type\":\"phrases\",\"key\":\"committer_name\",\"value\":\"GitHub, translatewiki.net, snyk-bot\",\"params\":[\"GitHub\",\"translatewiki.net\",\"snyk-bot\"],\"negate\":true,\"disabled\":false,\"alias\":null},\"query\":{\"bool\":{\"should\":[{\"match_phrase\":{\"committer_name\":\"GitHub\"}},{\"match_phrase\":{\"committer_name\":\"translatewiki.net\"}},{\"match_phrase\":{\"committer_name\":\"snyk-bot\"}}],\"minimum_should_match\":1}},\"$state\":{\"store\":\"appState\"}},{\"meta\":{\"index\":\"26d36150-0f7c-11ea-ae8c-d9e77f11fa16\",\"negate\":false,\"disabled\":false,\"alias\":null,\"type\":\"range\",\"key\":\"lines_changed\",\"value\":\"0 to 10,000\",\"params\":{\"gte\":0,\"lt\":10000}},\"range\":{\"lines_changed\":{\"gte\":0,\"lt\":10000}},\"$state\":{\"store\":\"appState\"}},{\"meta\":{\"index\":\"26d36150-0f7c-11ea-ae8c-d9e77f11fa16\",\"type\":\"phrases\",\"key\":\"Commit_name\",\"value\":\"Emmanuel Engelhart, renaud gaudin, Matthieu Gautier, Sean Mac Gillicuddy, Travis Briggs, Justin Biggs, Aditya Sood, Isaac Hutt, Geoffrey Kantaris, Joseph Reeve\",\"params\":[\"Emmanuel Engelhart\",\"renaud gaudin\",\"Matthieu Gautier\",\"Sean Mac Gillicuddy\",\"Travis Briggs\",\"Justin Biggs\",\"Aditya Sood\",\"Isaac Hutt\",\"Geoffrey Kantaris\",\"Joseph Reeve\"],\"negate\":false,\"disabled\":false,\"alias\":null},\"query\":{\"bool\":{\"should\":[{\"match_phrase\":{\"Commit_name\":\"Emmanuel Engelhart\"}},{\"match_phrase\":{\"Commit_name\":\"renaud gaudin\"}},{\"match_phrase\":{\"Commit_name\":\"Matthieu Gautier\"}},{\"match_phrase\":{\"Commit_name\":\"Sean Mac Gillicuddy\"}},{\"match_phrase\":{\"Commit_name\":\"Travis Briggs\"}},{\"match_phrase\":{\"Commit_name\":\"Justin Biggs\"}},{\"match_phrase\":{\"Commit_name\":\"Aditya Sood\"}},{\"match_phrase\":{\"Commit_name\":\"Isaac Hutt\"}},{\"match_phrase\":{\"Commit_name\":\"Geoffrey Kantaris\"}},{\"match_phrase\":{\"Commit_name\":\"Joseph Reeve\"}}],\"minimum_should_match\":1}},\"$state\":{\"store\":\"appState\"}}],\"query\":{\"language\":\"lucene\",\"query\":\"\"}}"

I use UI and export feature to generate this file.

Note : The UX is now in read only mode, we can't use to change the config.

@kelson42
Copy link
Collaborator Author

kelson42 commented Dec 2, 2020

@florentk I don't get it, can you please document in the README how to update the list of users?

@florentk
Copy link
Collaborator

florentk commented Dec 3, 2020

@kelson42 I've change the README to explain how change dashboard_overview.json : https://github.com/kiwix/metrics/blob/master/README.md#dashboard_overviewjson

@kelson42
Copy link
Collaborator Author

kelson42 commented Dec 3, 2020

@florentk Thank you. This is super cumbersome. The root is in the DB, but with use the git as a backup :( Will try to update that list.

@stale
Copy link

stale bot commented Feb 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants