-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove ONIG_MAX_CAPTURE_NUM and ONIGERR_TOO_MANY_CAPTURES #46
Comments
The capture numbers are expressed in a bytecode as short int. |
Can this be expanded to 64 bit and this limit made consistent with the limit typedef? |
Is it |
I'm really curious about your usage. |
I use rather large regular expressions to find certain terms in texts. There are a lot of terms, lists can be arbitrarily large. It works fine, except it hits this limit. So I suggest you increase the limit, so that nobody has to hit it again. 16-bit vs. 32-bit field doesn't really save much performance-wise. Also please make the limit consistent with the data type. |
I have updated develop branch. Default capture number limit (32767) is not changed. |
Thanks! |
There is no need to assume that regular expressions are small and to limit something with the arbitrary number 32767.
The text was updated successfully, but these errors were encountered: