Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: "fork" accessed_addresses and accessed_storage_keys from their parents when creating child_evm #569

Open
enitrat opened this issue Jan 27, 2025 · 0 comments
Milestone

Comments

@enitrat
Copy link
Collaborator

enitrat commented Jan 27, 2025

in generic_call or generic_create, we create new, empty dicts for the accessed storage keys of a child context. we use the tracker of the previous segment as the initial_dict, and copy all the entries of the dict access segment.

we could simply "fork" it from the parent dict with the original_mapping mechanism.

Definition of done:

  • delete dict_copy logic
  • update incorporate_child_on_success to use dict_update to merge the values with the parent dict (instead of squash_and_update, which is a function for dicts with unrelated histories)
  • in generic_call, generic_create, don't use dict_copy, but do as in copy_TrieAddressOptionalAccount with %{copy_dict_segment}
@github-project-automation github-project-automation bot moved this to Backlog in Keth Jan 27, 2025
@obatirou obatirou moved this from Backlog to In progress in Keth Jan 31, 2025
@obatirou obatirou moved this from In progress to Backlog in Keth Jan 31, 2025
@Eikix Eikix added this to the Optimization milestone Feb 3, 2025
@Eikix Eikix moved this from Backlog to Todo in Keth Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants