Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Args #146

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Add Args #146

merged 2 commits into from
Oct 4, 2016

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Sep 28, 2016

This would be a breaking change as command will now run with sh -c instead of the default entrypoint. Args will call the default entry point.

Should fix #100

@keis
Copy link
Collaborator

keis commented Sep 29, 2016

Thanks for the PR @Mongey. Could you update the README/swagger with this new option? Otherwise it LGTM.

IIRC the shell field defaults to true so this should not be a breaking change.

@alde
Copy link
Contributor

alde commented Sep 29, 2016

It does indeed default to true, so I see no issues here. 👍

@Mongey Mongey changed the title [WIP] Add Args Add Args Sep 29, 2016
@Mongey
Copy link
Contributor Author

Mongey commented Oct 3, 2016

IIRC the shell field defaults to true so this should not be a breaking change.

🙇 Cool, Anything else I need to get this merged?

@keis keis merged commit ee8a310 into eremetic-framework:master Oct 4, 2016
@Mongey Mongey deleted the cm-add-args-to-tasks branch April 16, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keis keis keis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launching tasks with image defined entrypoint
3 participants
@Mongey @keis @alde