Filter offers #31
Merged
Filter offers #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func matchOffer(task types.EremeticTask, offers []*mesos.Offer) (*mesos.Offer, []*mesos.Offer) { | ||
| var matcher = makeMatcher(task) |
There was a problem hiding this comment.
think I'd prefer createMatcher instead of makeMatcher
makeMatcher sounds weird in my head
There was a problem hiding this comment.
yeah. I'll change that. it's also a bit confusing when there already is the built in make() construct in the language
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop eremetic from trying to launch tasks on offers without enough resources.
Future improvements are to perhaps give up on a task if we can't launch it after X minutes. Also right now it freaks out and rejects all offers when a task can't be launched