Create a database abstraction #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func wrap(db *bolt.DB) TaskDB { | ||
| wrapped := boltDriver{} |
There was a problem hiding this comment.
it's a bit verbose I would prefer
return boltDriver{
database: db,
}
alde
force-pushed
the
create-database-abstraction
branch
from
f1fe3a5 to
b081959
Compare
In order to prepare for adding support for more different databases, an abstraction for the database drivers is needed.
alde
force-pushed
the
create-database-abstraction
branch
from
b081959 to
ea9fd71
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prepare for adding support for more different databases, an
abstraction for the database drivers is needed.