Provide access to sandbox logs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2016 19:08
using the /task/<task_id>/{stdout,stderr} endpoint it is possible to
fetch the output from the run.
alde
force-pushed
the
provide-access-to-sandbox-logs
branch
from
a54103c to
1528cfc
Compare
| return | ||
| } | ||
| defer response.Body.Close() | ||
| body, err := ioutil.ReadAll(response.Body) |
There was a problem hiding this comment.
This could be buffering several MB of data before starting the response. I think go has some method for writing a stream directly to a http response.
added 2 commits
June 8, 2016 22:00
Also clean up the handler a bit.
| ) | ||
|
|
||
| // getFile handles the actual fetching of file from the agent. | ||
| func getFile(file string, task types.EremeticTask) (int, interface{}) { |
There was a problem hiding this comment.
interface{} => something
io.ReadCloser ?
There was a problem hiding this comment.
not sure how that'd work with the string returns, but maybe the string returns are wrong
There was a problem hiding this comment.
aha, I see. maybe it should actually be (err, io.whatever) and the "Unable to fetch upstream file" could be the message of the error object?
|
Looks good to me. GetFile still looks a bit iffy but I have no excellent suggestions at this time. If it gets the job done, eh? |
|
Yeah, I think it's good for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add /stdout and /stderr endpoints on a task resource to access logs from the sandbox