Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent-ffmpeg spawn process called twice if pipe() used #1

Open
luigixx73 opened this issue Feb 13, 2024 · 1 comment
Open

Fluent-ffmpeg spawn process called twice if pipe() used #1

luigixx73 opened this issue Feb 13, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@luigixx73
Copy link

Please check out this code in /base/transcoder.ts.
Lines 105 --
As using pipe() involves run() it is called twice spawning the process twice and producing 2 output streams which mess the resulting video in gliches.
So, a good solution is to put that part of code inside the else { } block when there is no custom output function.

this._promise = new Promise((resolve) => {
this._command.on('end', resolve).run();
});

@kldzj
Copy link
Owner

kldzj commented Feb 13, 2024

Hey there, thanks for spotting this issue.

Would you mind creating a PR for this?

@kldzj kldzj added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants