Bug: File Uploads not working

[mr-karan]

Steps to reproduce

• Downloaded the latest release from github:
  curl -sL https://github.com/knadh/listmonk/releases/download/v0.2.2-alpha/listmonk_0.2.2-alpha_linux_amd64.tar.gz | tar xz

• Created a new config file
  ./listmonk --new-config

• Spawned an ephemeral postgres container
  docker run -p 5432:5432 -e "POSTGRES_DB=listmonk" -e "POSTGRES_USER=listmonk" -e "POSTGRES_PASSWORD=listmonk" postgres:latest

• Configured DB
  ./listmonk --install

• Created an uploads folder in the current directory
  mkdir uploads

• Started listmonk
  ./listmonk

• Visited http://localhost:9000/campaigns/media and uploaded a file
  

What happened
Got a 404 on the uploaded file. http://localhost:9000/uploads/DeepinScreenshot_select-area_20191009181805.png

Expected scenario
The file should have been previewed correctly, not 404.

[mr-karan]

Figured. Looks like a typo here
should have been: srv.Static(c.UploadURI, c.UploadPath)

Will send a patch with #22 ?

[knadh]

Yep, looks like it's a typo. I'm not sure how it's working in production though.

[3sigma-devops]

error uploading file: open uploads/profile_logo_UVBGW_a5c39e85beb37d2090c7ab84b9b12381.jpg: no such file or directory
2021/09/08 08:20:38error uploading file: open uploads/FireShot Capture 109 - threesigma-backend-production · Metrics - Heroku - dashboard.heroku.com.png: no such file or directory

I am facing this same issue while uploading media

[knadh]

Have you mounted a filesystem and made an uploads directory and set that path in the upload settings? On an ordinary Linux server, this would be straight forward, but on Heroku, you've to do this manually.

[ntmoin]

Hi, Knadh,
Good day!
I have installed several times the listmonk latest version following/using___

mkdir listmonk && cd listmonk
sh -c "$(curl -fsSL https://raw.githubusercontent.com/knadh/listmonk/master/install-prod.sh)"
Visit http://localhost:9000.

Anyway, each and everytime I am facing the same file upload error as___

Error uploading file: open /root/listmonk/uploads/emailsecurityconciousness.jpg: no such file or directory

Yes of course in my ubuntu 20.04 machine I have created the 'uploads' directory in my project directory. Like_
Project path: /root/listmonk
Upload folder: /root/listmonk/uploads

Please help for the resolution.

[ntmoin]

[knadh]

Looks like the directory is not mounted in the container. @mr-karan would you be able to take a look?

[mr-karan]

Yeah, /root/listmonk/uploads/ is the path inside container, which likely doesn't exist.

You'll need to mount the upload folder to the container. Edit this in your docker-compose:

    volumes:
    - ./path/on/your/host/:/path/inside/container

The value of path/inside/container is the one you should use in the Listmonk settings. This will ensure that the files uploaded are persistent.

[ntmoin]

Thank you so much 'Mr. knadh' & 'Mr. mr-karan'.

[MaximilianKohler]

Yeah, /root/listmonk/uploads/ is the path inside container, which likely doesn't exist.

You'll need to mount the upload folder to the container. Edit this in your docker-compose:

    volumes:
    - ./path/on/your/host/:/path/inside/container

The value of path/inside/container is the one you should use in the Listmonk settings. This will ensure that the files uploaded are persistent.

Per the docs I'm using this:

services:
  app:
    <<: *app-defaults
    container_name: listmonk_app
    depends_on:
      - db
    volumes:
      - ./config.toml:/listmonk/config.toml
      - type: volume
        source: listmonk-uploads
        target: /listmonk/uploads

volumes:
  listmonk-data:
  listmonk-uploads:

Are you saying we should use one or both of these?:

services:
  app:
    <<: *app-defaults
    container_name: listmonk_app
    depends_on:
      - db
    volumes:
      - ./config.toml:/listmonk/config.toml
      - ./home/ubuntu/listmonk/uploads:/listmonk/uploads

volumes:
  listmonk-data:
  - ./home/ubuntu/listmonk/uploads:/listmonk/uploads

Also, the docs show this (no period and one space indent):

    volumes:
      - /data/uploads:/listmonk/uploads

And you say:

    volumes:
    - ./path/on/your/host/:/path/inside/container

EDIT: mostly solved here: #1169 (comment)