From e6ed9e9b95773b21629c03acf1dd64d7250e9741 Mon Sep 17 00:00:00 2001 From: Evgenii Kliuchnikov Date: Mon, 11 Dec 2023 09:29:31 +0000 Subject: [PATCH] Change order of checks. Basically that is no-op, unless function is called from auto-generated fuzzer. (those does stupid thing: for 0-sized vector it takes .data(); changing order of checks we avoid touching that invalid pointer) --- libfaad/decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libfaad/decoder.c b/libfaad/decoder.c index 4649c6e6..c04da526 100644 --- a/libfaad/decoder.c +++ b/libfaad/decoder.c @@ -837,7 +837,7 @@ void* NeAACDecDecode2(NeAACDecHandle hpDecoder, unsigned long sample_buffer_size) { NeAACDecStruct* hDecoder = (NeAACDecStruct*)hpDecoder; - if ((sample_buffer == NULL) || (*sample_buffer == NULL) || (sample_buffer_size == 0)) + if ((sample_buffer_size == 0) || (sample_buffer == NULL) || (*sample_buffer == NULL)) { hInfo->error = 27; return NULL;