From 2c6815620c5b6abd5a20b062b1a778f0f6480148 Mon Sep 17 00:00:00 2001 From: TSenter Date: Thu, 1 Aug 2024 17:32:00 -0400 Subject: [PATCH] refactor: Use Glimmer TS files for tests --- .../{alert-test.ts => alert-test.gts} | 17 +++-- ...on-group-test.ts => button-group-test.gts} | 71 ++++++++++++------- .../{button-test.ts => button-test.gts} | 44 ++++++------ .../{card-test.ts => card-test.gts} | 21 +++--- .../{footer-test.ts => footer-test.gts} | 46 ++++++------ .../{header-test.ts => header-test.gts} | 13 ++-- ...tor-test.ts => loading-indicator-test.gts} | 10 +-- ...tainer-test.ts => card-container-test.gts} | 10 +-- .../mktg/{card-test.ts => card-test.gts} | 69 +++++++++--------- .../mktg/{faq-test.ts => faq-test.gts} | 27 ++++--- .../{mktg-header-test.ts => header-test.gts} | 20 +++--- ...ainer-test.ts => promo-container-test.gts} | 19 ++--- .../mktg/{promo-test.ts => promo-test.gts} | 66 ++++++++--------- .../{progress-test.ts => progress-test.gts} | 24 +++---- 14 files changed, 241 insertions(+), 216 deletions(-) rename packages/ember-test-app/tests/integration/components/{alert-test.ts => alert-test.gts} (87%) rename packages/ember-test-app/tests/integration/components/{button-group-test.ts => button-group-test.gts} (61%) rename packages/ember-test-app/tests/integration/components/{button-test.ts => button-test.gts} (80%) rename packages/ember-test-app/tests/integration/components/{card-test.ts => card-test.gts} (70%) rename packages/ember-test-app/tests/integration/components/{footer-test.ts => footer-test.gts} (62%) rename packages/ember-test-app/tests/integration/components/{header-test.ts => header-test.gts} (92%) rename packages/ember-test-app/tests/integration/components/{loading-indicator-test.ts => loading-indicator-test.gts} (79%) rename packages/ember-test-app/tests/integration/components/mktg/{card-container-test.ts => card-container-test.gts} (83%) rename packages/ember-test-app/tests/integration/components/mktg/{card-test.ts => card-test.gts} (82%) rename packages/ember-test-app/tests/integration/components/mktg/{faq-test.ts => faq-test.gts} (79%) rename packages/ember-test-app/tests/integration/components/mktg/{mktg-header-test.ts => header-test.gts} (79%) rename packages/ember-test-app/tests/integration/components/mktg/{promo-container-test.ts => promo-container-test.gts} (67%) rename packages/ember-test-app/tests/integration/components/mktg/{promo-test.ts => promo-test.gts} (61%) rename packages/ember-test-app/tests/integration/components/{progress-test.ts => progress-test.gts} (83%) diff --git a/packages/ember-test-app/tests/integration/components/alert-test.ts b/packages/ember-test-app/tests/integration/components/alert-test.gts similarity index 87% rename from packages/ember-test-app/tests/integration/components/alert-test.ts rename to packages/ember-test-app/tests/integration/components/alert-test.gts index c673fe32e..a798b4759 100644 --- a/packages/ember-test-app/tests/integration/components/alert-test.ts +++ b/packages/ember-test-app/tests/integration/components/alert-test.gts @@ -8,6 +8,7 @@ import { type TestContext, } from '@ember/test-helpers'; import { hbs } from 'ember-cli-htmlbars'; +import Alert from '@nrg-ui/ember/components/alert'; interface Context extends TestContext { dismissHandler: () => void; @@ -17,12 +18,13 @@ module('Integration | components | alert', function (hooks) { setupRenderingTest(hooks); test('it renders', async function (assert) { - await render(hbs` + await render(); assert .dom('div.alert') @@ -70,16 +72,17 @@ module('Integration | components | alert', function (hooks) { let actionFired = false; - this.dismissHandler = () => { + const dismissHandler = () => { actionFired = true; }; - await render(hbs` + await render(); await click('button'); await clearRender(); diff --git a/packages/ember-test-app/tests/integration/components/button-group-test.ts b/packages/ember-test-app/tests/integration/components/button-group-test.gts similarity index 61% rename from packages/ember-test-app/tests/integration/components/button-group-test.ts rename to packages/ember-test-app/tests/integration/components/button-group-test.gts index 9fce4d24d..5a0c1b184 100644 --- a/packages/ember-test-app/tests/integration/components/button-group-test.ts +++ b/packages/ember-test-app/tests/integration/components/button-group-test.gts @@ -1,7 +1,8 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; import { click, render, type TestContext } from '@ember/test-helpers'; -import { hbs } from 'ember-cli-htmlbars'; +import { fn } from '@ember/helper'; +import ButtonGroup from '@nrg-ui/ember/components/button-group'; interface Context extends TestContext { clickHandler: (type: string, evt: MouseEvent) => void; @@ -13,16 +14,16 @@ module('Integration | components | button-group', function (hooks) { test('it renders', async function (this: Context, assert) { assert.expect(9); - this.clickHandler = (type: string, evt: MouseEvent) => { + const clickHandler = (type: string, evt: MouseEvent) => { assert.step(type); assert.ok(evt, 'action is fired with event'); }; - await render(hbs` - - + await render(); assert.dom('div:has(button)').hasAttribute('role', 'group'); @@ -43,17 +44,21 @@ module('Integration | components | button-group', function (hooks) { test('a disabled group disables all buttons', async function (this: Context, assert) { assert.expect(6); - this.clickHandler = (type: string, evt: MouseEvent) => { + const clickHandler = (type: string, evt: MouseEvent) => { assert.notOk(type); assert.notOk(evt, 'action is fired with event'); }; - await render(hbs` - - - + await render(); assert .dom('div:has(button)') @@ -77,20 +82,36 @@ module('Integration | components | button-group', function (hooks) { test('nested groups fire actions', async function (this: Context, assert) { assert.expect(16); - this.clickHandler = (type: string, evt: MouseEvent) => { + const clickHandler = (type: string, evt: MouseEvent) => { assert.step(type); assert.ok(evt, 'action is fired with event'); }; - await render(hbs` - - - - - + await render(); assert.dom('div:has(button)').hasAttribute('role', 'group'); @@ -118,19 +139,19 @@ module('Integration | components | button-group', function (hooks) { test('nested groups fire only one action per event', async function (this: Context, assert) { assert.expect(1); - this.clickHandler = (type: string, evt: MouseEvent) => { + const clickHandler = (type: string, evt: MouseEvent) => { assert.ok(evt, 'action is fired with event'); }; - await render(hbs` - + await render(); await click('button'); }); diff --git a/packages/ember-test-app/tests/integration/components/button-test.ts b/packages/ember-test-app/tests/integration/components/button-test.gts similarity index 80% rename from packages/ember-test-app/tests/integration/components/button-test.ts rename to packages/ember-test-app/tests/integration/components/button-test.gts index 5a0d81209..049cdbc56 100644 --- a/packages/ember-test-app/tests/integration/components/button-test.ts +++ b/packages/ember-test-app/tests/integration/components/button-test.gts @@ -1,7 +1,7 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; import { click, findAll, render, type TestContext } from '@ember/test-helpers'; -import { hbs } from 'ember-cli-htmlbars'; +import Button from '@nrg-ui/ember/components/button'; interface Context extends TestContext { clickHandler: (evt: MouseEvent) => void; @@ -13,13 +13,13 @@ module('Integration | components | button', function (hooks) { test('it renders', async function (this: Context, assert) { assert.expect(12); - this.clickHandler = (evt: MouseEvent) => { + const clickHandler = (evt: MouseEvent) => { assert.ok(evt, 'action is fired with event'); }; - await render( - hbs`