Make KO_DOCKER_REPO configurable

[embano1]

It would be nice to have KO_DOCKER_REPO being part of the inputs, e.g.

- uses: imjasonh/[email protected]
  with:
    version: v0.8.0
    KO_DOCKER_REPO: kind.local # later passed/injected as env var

This would avoid an additional step for the user to export the variable.

[imjasonh]

With the current version if a user wants to set KO_DOCKER_REPO to something else, they can, we just give a default:

steps:
- uses: imjasonh/[email protected]
- run: KO_DOCKER_REPO=kind.local ko publish ./

or:

steps:
- uses: imjasonh/[email protected]
- env:
    KO_DOCKER_REPO: kind.local
  run: ko publish ./

edit: but not this:

env:
  KO_DOCKER_REPO: kind.local
steps:
- uses: imjasonh/[email protected]
- run: ko publish ./

(setup-ko seems to overwrite the workflow-wide env in this case)

That might still be confusing, since if a user forgets to set it for one step it'll revert back to KO_DOCKER_REPO=ghcr.io/....

It might make more sense to take an input to disable the ghcr-setting at all, so it doesn't login and doesn't set KO_DOCKER_REPO at all. At least that way if you forget to set it it'll fail loudly instead of silently "helpfully" defaulting to ghcr.

[embano1]

Thx. Instead of disabling as an option, which option do you think is most common?

• Use your action and set/customize that env variable as part of the job step and export it for downstream jobs
• Use your action and set/customize that env variable locally (action) and make it available for downstream jobs via id.output reference syntax
• Define this var in a global env section, honored by this action if defined, otherwise overwrite and export with a default

I think inject as env (3) would probably be most flexible as it can be easily used elsewhere, eg to later pull this image etc by globally defining it (job vs action-level).

[imjasonh]

Yeah I think I like not setting it if it's already set when it gets to the action. That's easy to describe and easy to implement.

Thanks for the suggestion!

[imjasonh]

Fixed in https://github.com/imjasonh/setup-ko/releases/tag/v0.4