Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forEach should be rewritten to for loop for optimized boot performance #42

Closed
niftylettuce opened this issue Dec 25, 2019 · 4 comments · Fixed by #50
Closed

forEach should be rewritten to for loop for optimized boot performance #42

niftylettuce opened this issue Dec 25, 2019 · 4 comments · Fixed by #50

Comments

@niftylettuce
Copy link
Contributor

No description provided.

@golopot
Copy link

golopot commented Jan 9, 2020

Do you mean ES1 for loop or ES6 for of loop?

@kravorkid
Copy link

@golopot Guess he is talking about a classic ES1 for loop seems to be much faster than a for of

@niftylettuce
Copy link
Contributor Author

Correct

@JacobMGEvans
Copy link
Contributor

I may take a look at this.

I'll use the counter for over the for of as suggested.

@JacobMGEvans JacobMGEvans mentioned this issue Feb 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/for each to forloops JacobMGEvans/router
4 participants
@niftylettuce @golopot @kravorkid @JacobMGEvans