Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequence to NFT #27

Open
vikiival opened this issue Jun 15, 2023 · 0 comments
Open

Add sequence to NFT #27

vikiival opened this issue Jun 15, 2023 · 0 comments

Comments

@vikiival
Copy link
Member

to NFTEntity add new field sequence that should be either BigInt or Int

type NFTEntity @entity {
sequence: BigInt! // or Int!
}

How to fill that?

Derive the number value from sn

sn = '00000000000008'
sequence = BigInt(sn)

Why

Because sorting based on SN is not correct (because sn is String)

Why Int or BigInt?

I am not sure how bigint would behave in sort (maybe check first some ordering via blockNumber if it's correctly sorted)

Have you considered any alternatives?

Yeah the other alternative is to remap sn into BigInt or Int but I am not sure what will we break on frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant