Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fees #4038

Closed
1 task done
vikiival opened this issue Sep 28, 2022 · 2 comments
Closed
1 task done

Implement fees #4038

vikiival opened this issue Sep 28, 2022 · 2 comments
Labels
A-basilisk issues related to basilisk parachain A-research we will research on these bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@vikiival
Copy link
Member

What happened?

Currently we do not take fees on Basilisk for sales.

Please reproduce in steps

Go to snek
List NFT
Sell
No tokens goes to the fund

Expected Behavior

How to implement:

  • in Available actions check if action is buy
  • use api.tx.utility.batchAll
  • Where first arg is the buy callback cb(…args)
  • Second I have to check since we use non-native tokens

What browsers are you seeing the problem on?

No response

At which address did you encounter bug?

No response

Are you logged in?

No response

Which wallet you are using?

No response

Screenshots

~

Relevant log output

No response

Payment link for reward

https://kodadot.xyz/transfer/?target=%3CMy_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address%3E

Code of Conduct

  • I agree to follow this project's Code of Conduct
@vikiival vikiival added bug Something isn't working p2 core functionality, or is affecting 60% of app A-basilisk issues related to basilisk parachain A-research we will research on these labels Sep 28, 2022
@yangwao
Copy link
Member

yangwao commented Sep 28, 2022

I guess two options could be done is

  • natively through proxied royalties, there fore bsx devs would need to extend pallet for it, so we can put our address own royalty and open doors for some revenue sharing
  • adding it through the proposed solution above

@roiLeo roiLeo mentioned this issue Mar 2, 2023
Closed
@vikiival
Copy link
Member Author

vikiival commented Mar 2, 2023

Continue in #5130

@vikiival vikiival closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-basilisk issues related to basilisk parachain A-research we will research on these bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangwao @vikiival