Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-Request] Instead of a fixed sleep - check DNS record and if not found, then sleep #1

Open
ThaDaVos opened this issue Sep 1, 2024 · 0 comments

Comments

@ThaDaVos
Copy link

ThaDaVos commented Sep 1, 2024

Currently the hook sleeps for whatever time it takes which is set for the propagation duration, I didn't check the code beforehand so I set it to the same value as my DNS Providers TTL - which is 1800s - but then I figured out it's just a hard coded sleep and not checking if the record exists before hand.

So, a improvement I can recommend is to check the record for the existence - then if non-existent, wait the mentioned propagation duration - or maybe even, sleep for max X seconds, then check again till a max of the propagation duration and if it doesn't exist after that, exit with an error - this should also prevent unnecessary calls to LetsEncrypt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant