Introduce the Download#FailOnError option. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change also adds logging of download operations to the wrapper log
|
Hi Oleg, I updated the pull request. Have a look to it and give me a hint how to proceed. |
Conflicts: src/Core/WinSWCore/Download.cs src/Test/winswTests/Util/ConfigXmlBuilder.cs
|
@nightman68 FYI will merge it to the master and then refactor and finalize both changes |
|
Sounds good 👍 Waiting that it is integrated in Jenkins LTS. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows preventing the executable start if the requested file cannot be downloaded. It also adds logging of download operations to the wrapper log.
The approach still needs to be finalized, because
FailOnErrordoes not propagate errors to thestartcommand (as all other similar commands)CC @nightman68 I just decided to write it in order to provide an example. If you want, I can integrate your auth proposals in the same way.