Finalize the Download Command changes #203
Conversation
|
@nightman68 Ready for review. CC @reviewbybees just in case |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
examples/sample-allOptions.xml
Outdated
| username="aUser" password=“aPassw0rd" /> | ||
|
|
||
| Secure Basic authentication via HTTPS: | ||
| <download from="https://example.com/some.dat" to="%BASE%\some.dat" | ||
| auth="basic" username="aUser" password="aPassw0rd" /> | ||
|
|
||
| Secure authentication when the target server and the client are members of domain: | ||
| Secure authentication when the target server and the client are members of the same domain: |
There was a problem hiding this comment.
The membership in "the same" domain is normally not the constraint. When a forest trust is defined correctly it is also working.
There was a problem hiding this comment.
Right. "of domain" does not seem the best wording as well. Could it be there a better clarification text?
There was a problem hiding this comment.
Right .-) My proposal:
Secure authentication when the target server and the client are members of the same domain or the server domain and the client domain belong to the same forest with a trust.
|
Seems it is ready to go |
This PR finalizes #126, which includes #194 from @nightman68 and #195 from me.
unsecureAuthto the boolean flag, update docsauthfield case-insensitive