Introduced the following new elements. #247

DHirani · 2017-08-29T13:20:07Z

logname - you can override the name of the log file rather than using the EXE name, this means you don't have to call your EXE a different name, just name the winsw exe different. Default's the name to the EXE as before.
outfiledisabled - you can disable writing to the out file. Defaults to false.
errfiledisabled - you can disable writing to the error file. Defaults to false.
outfilepattern - you can choose the pattern of the out file. Defaults to .out.log.
errfilepattern - you can choos the pattern of the error file. Defaults to .err.log.

1. logname - you can override the name of the log file rather than using the EXE name, this means you don't have to call your EXE a different name, just name the winsw exe different. Default's the name to the EXE as before. 2. outfiledisabled - you can disable writing to the out file. Defaults to false. 3. errfiledisabled - you can disable writing to the error file. Defaults to false. 4. outfilepattern - you can choose the pattern of the out file. Defaults to .out.log. 5. errfilepattern - you can choos the pattern of the error file. Defaults to .err.log.

oleg-nenashev

I was planning to do such things as sample configurations in #213, but it makes sense to have separate controls since somebody is ready to spend time on this. Thanks!

The PR needs some polishing, fix of the Default error log, and some unit tests. The default options roundtrip is automatic, but it does not catch things like wrong defaults and XML patterns

oleg-nenashev · 2017-08-29T13:35:41Z

src/Core/WinSWCore/WinSWCore.csproj

@@ -33,7 +33,7 @@
  </PropertyGroup>
  <PropertyGroup>
    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>$(SolutionDir)..\winsw_key.snk</AssemblyOriginatorKeyFile>
+    <AssemblyOriginatorKeyFile>winsw_key.snk</AssemblyOriginatorKeyFile>


It does not work correctly on the solution level, at least in my IDE

oleg-nenashev · 2017-08-29T13:36:07Z

src/Core/WinSWCore/Configuration/DefaultSettings.cs

+        public bool OutFileDisabled { get { return false; } }
+        public bool ErrFileDisabled { get { return false; } }
+        public string OutFilePattern { get { return ".out.log"; } }
+        public string ErrFilePattern { get { return ".out.log"; } }


Copy-paste error ?

oleg-nenashev · 2017-08-29T13:36:56Z

src/Core/ServiceWrapper_dotNET4/manifest.xml

@@ -0,0 +1,10 @@
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+  <assemblyIdentity version="1.0.0.0" name="winsw" type="win32"/>


Version needs to be patched in the build flow if you want to include it to the release

Removed the file should not been created.

oleg-nenashev · 2017-08-29T13:38:37Z

src/Core/WinSWCore/ServiceDescriptor.cs

@@ -355,6 +362,49 @@ public string LogMode
            }
        }

+        public string LogName


Imho all the options should be defined in the <logging> tag

I've followed the same logic as logmode, logpath, let me know if its wrong.

ack, will need to think about it twice.

oleg-nenashev · 2017-08-29T13:38:59Z

src/Core/ServiceWrapper_dotNET4/winsw.xml

@@ -0,0 +1,308 @@
+<!--


Why would you need this file?

oleg-nenashev · 2017-08-29T13:39:28Z

src/Core/WinSWCore/WinSWCore.csproj

@@ -73,6 +73,7 @@
  </ItemGroup>
  <ItemGroup>
    <None Include="packages.config" />
+    <None Include="winsw_key.snk" />


The SNK must not be included into the repo

oleg-nenashev

There are still src/.vs/winsw/v15/sqlite3/storage.ide and *.snk files added

DHirani · 2017-08-29T14:55:21Z

Removed the snk file and sqllite file

…led and errfilepattern. Created a new appender called roll-by-size-time see class RollingSizeTimeLogAppender, this appender supports rolling by time and size and rolling at a specific time each day. Added unit test for the new appender. Added a new option testwait which is similar to test but waits for the user to press any key before calling the stop method.

oleg-nenashev

The change mostly looks good to me. Ideally it should have been submitted as separate pull requests, but I can live with the current state as well.

I will need to do some manual testing before the merging. Due to the conference period, it may take a while (1-2 weeks) before I actually release the change. Is it fine for you?

oleg-nenashev · 2017-08-31T13:20:28Z

src/Core/WinSWCore/LogAppenders.cs

+                if (nextFileNumber == 0) throw new IOException("Cannot roll the file because matching pattern not found");
+                nextFileNumber++;
+            }
+            return nextFileNumber;


There is some copy-paste in this appender, but OK for now

That is fine I will use my fork version until you merge it.

Hi let me know when you planning to merge this into master.

My optimistic plan - this Saturday

oleg-nenashev · 2017-08-31T13:21:29Z

src/Core/WinSWCore/ServiceDescriptor.cs

@@ -355,6 +362,49 @@ public string LogMode
            }
        }

+        public string LogName


ack, will need to think about it twice.

oleg-nenashev · 2017-09-18T16:21:58Z

Tested it a bit yesterday, looks good to me.
I will write some documentation for that before the release

DHirani · 2017-09-19T08:28:24Z

Thanks for pushing the change into master, when will the package be available from nuget?

oleg-nenashev · 2017-09-22T12:29:09Z

@DHirani it will be officially released once I update documentation to reflect the new features (README, logging page, config samples). It may take a while, but I will be happy to review the PRs if you have some time to work on them.

Anyway, the code looks good, so the documentation should not take much time

DHirani added 2 commits August 29, 2017 14:16

Downgraded from C#7.0 syntax.

cacc854

oleg-nenashev requested changes Aug 29, 2017

View reviewed changes

Applied reviewers comment

b26a4b6

oleg-nenashev requested changes Aug 29, 2017

View reviewed changes

DHirani added 2 commits August 29, 2017 15:51

not required

b1691b9

removed the key

f495418

DHirani and others added 6 commits August 31, 2017 13:35

Update loggingAndErrorReporting.md

01f5ad7

Cannot use $ string.format syntax, downgraded code to string.format.

bfa35d4

Merge branch 'master' of https://github.com/dhirani/winsw

694e67d

Another syntax found of $

2311d7b

Fixed a unit tests

90ada7e

oleg-nenashev self-assigned this Aug 31, 2017

oleg-nenashev reviewed Aug 31, 2017

View reviewed changes

oleg-nenashev merged commit 221d30f into winsw:master Sep 18, 2017

oleg-nenashev mentioned this pull request Jan 3, 2019

FATAL - Unhandled exception System.IO.InvalidDataException: UnHdefined logging mode: roll-by-size-time #296

Closed

nxtn added this to the 2.2.0 milestone Mar 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduced the following new elements. #247

Introduced the following new elements. #247

DHirani commented Aug 29, 2017

oleg-nenashev left a comment

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev Aug 31, 2017

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev Aug 29, 2017

DHirani Aug 29, 2017

oleg-nenashev left a comment

DHirani commented Aug 29, 2017

oleg-nenashev left a comment

oleg-nenashev Aug 31, 2017

DHirani Aug 31, 2017

DHirani Sep 14, 2017

oleg-nenashev Sep 14, 2017

oleg-nenashev Aug 31, 2017

oleg-nenashev commented Sep 18, 2017

DHirani commented Sep 19, 2017

oleg-nenashev commented Sep 22, 2017

		@@ -0,0 +1,10 @@
		<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
		<assemblyIdentity version="1.0.0.0" name="winsw" type="win32"/>

Introduced the following new elements. #247

Introduced the following new elements. #247

Conversation

DHirani commented Aug 29, 2017

oleg-nenashev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleg-nenashev left a comment

Choose a reason for hiding this comment

DHirani commented Aug 29, 2017

oleg-nenashev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleg-nenashev commented Sep 18, 2017

DHirani commented Sep 19, 2017

oleg-nenashev commented Sep 22, 2017